Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcloud: Added support for routers and gateways #17

Open
wants to merge 8 commits into
base: v2.24.1+k8s_node_inconsistencies_fix+terraform_openstack_mission_provider+upcloud-private-zone+upcloud-server-groups
Choose a base branch
from
Open

Upcloud: Added support for routers and gateways #17

wants to merge 8 commits into from

Conversation

Xartos
Copy link

@Xartos Xartos commented Jul 8, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #elastisys/compliantkubernetes-kubespray#333

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@Xartos Xartos requested review from viktor-f and removed request for davidumea July 16, 2024 07:22
Pavan-Gunda
Pavan-Gunda approved these changes Jul 16, 2024
View reviewed changes
Copy link

@Pavan-Gunda Pavan-Gunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this but LGTM

aarnq
aarnq reviewed Jul 16, 2024
View reviewed changes
Copy link

@aarnq aarnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not good at this so I'll leave the approval to someone who knows terraform better.

contrib/terraform/upcloud/README.md Outdated Show resolved Hide resolved
contrib/terraform/upcloud/modules/kubernetes-cluster/main.tf Outdated Show resolved Hide resolved
@Xartos Xartos requested a review from viktor-f July 17, 2024 06:01
viktor-f
viktor-f reviewed Jul 17, 2024
View reviewed changes
Copy link

@viktor-f viktor-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some misses when you changed the name. I think this is all of them

contrib/terraform/upcloud/README.md Outdated Show resolved Hide resolved
contrib/terraform/upcloud/modules/kubernetes-cluster/variables.tf Outdated Show resolved Hide resolved
contrib/terraform/upcloud/modules/kubernetes-cluster/variables.tf Outdated Show resolved Hide resolved
contrib/terraform/upcloud/variables.tf Outdated Show resolved Hide resolved
contrib/terraform/upcloud/variables.tf Outdated Show resolved Hide resolved
contrib/terraform/upcloud/README.md Outdated Show resolved Hide resolved
contrib/terraform/upcloud/README.md Outdated Show resolved Hide resolved
contrib/terraform/upcloud/README.md Outdated Show resolved Hide resolved
contrib/terraform/upcloud/main.tf Outdated Show resolved Hide resolved
contrib/terraform/upcloud/modules/kubernetes-cluster/variables.tf Outdated Show resolved Hide resolved
@Xartos Xartos requested a review from viktor-f July 17, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidumea davidumea davidumea left review comments

@aarnq aarnq aarnq left review comments

@Pavan-Gunda Pavan-Gunda Pavan-Gunda approved these changes

@viktor-f viktor-f viktor-f approved these changes

@lucianvlad lucianvlad Awaiting requested review from lucianvlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xartos @davidumea @Pavan-Gunda @viktor-f @aarnq