-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcloud: Added support for routers and gateways #17
base: v2.24.1+k8s_node_inconsistencies_fix+terraform_openstack_mission_provider+upcloud-private-zone+upcloud-server-groups
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test this but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not good at this so I'll leave the approval to someone who knows terraform better.
contrib/terraform/upcloud/modules/kubernetes-cluster/variables.tf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some misses when you changed the name. I think this is all of them
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #elastisys/compliantkubernetes-kubespray#333
Special notes for your reviewer:
Does this PR introduce a user-facing change?: