Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update opensearch dashboards index name in dr docs #1002

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

lunkan93
Copy link
Contributor

@lunkan93 lunkan93 commented Dec 2, 2024

⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:

  • personal data beyond what is necessary for interacting with this Pull Request;
  • business confidential information, such as customer names.

Quality gates:

  • I'm aware of the Contributor Guide and did my best to follow the guidelines.
  • I'm aware of the Glossary and did my best to use those terms.

See PR in Apps for context

Copy link
Contributor

@OlleLarsson OlleLarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@linus-astrom linus-astrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but since the reporting feature appears to be working now do we also want to change this line? by just remove the part about reporting not working.

@OlleLarsson
Copy link
Contributor

LGTM but since the reporting feature appears to be working now do we also want to change this line? by just remove the part about reporting not working.

Maybe open a draft pr with the change and merge it once the feature is working as intended again in the managed environments?

@lunkan93
Copy link
Contributor Author

lunkan93 commented Dec 4, 2024

Draft PR for reporting feature

@lunkan93 lunkan93 force-pushed the simonl/update-dr-doc branch from 2c30de5 to 5f56798 Compare December 5, 2024 11:07
@lunkan93 lunkan93 merged commit 9bb050b into main Dec 12, 2024
1 check passed
@lunkan93 lunkan93 deleted the simonl/update-dr-doc branch December 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants