-
Notifications
You must be signed in to change notification settings - Fork 22
Updated typescript library template #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bbottema
wants to merge
19
commits into
elboman:master
Choose a base branch
from
bbottema:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the build script really is. Cleaned up missing/trailing comma's etc.
…s (used for building the distribution)
…(it wouldn't use it's own library, but it would export everything in a 'barrel' index, so all types can be required from one import)
…, which is configured to be excluded from the distribution, so users are free to omit it or choose their own version. It doesn't affect the dist size at all.
…MIT, you committed it this year)
… libraries need this, for example when working with Angular2+
bbottema
commented
Jun 3, 2017
export * from './Greeter'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This an example of a 'barrel' index, where a library re-exports everything in a single index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Marco,
Thank you so much for your template, it was an incredible help for me after researching this topic for a very long time.
I updated your template and every change is a separate commit so you can see exactly what I did and why. I hope you will incorporate some of these updates!
Warm regards,