Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to work with current webpack (4.x) and UglifyJS #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrheling
Copy link

Your example was really helpful as I worked through packaging a typescript component (thanks!), but I found a handful of details that no longer worked as illustrated in the example. I can't say with confidence that the attached is optimal, but it seems to produce the desired result, and I think is functionally equivalent to the original (but in a way that works with current versions of things).

@lwojcik
Copy link

lwojcik commented Aug 26, 2020

@jrheling I just stopped by to say thank you for this pull request, it saved me a lot of time. The fact this otherwise excellent article is outdated is hard to spot unless you look at a comment section (lack of publication dates alongside article titles doesn't help either) and it's particularly problematic because it still ranks high in Google search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants