Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sendgrid 4 #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcraciunoiu
Copy link

Tested this on a simple django 1.11 configuration.

See SendGrid changelog:

@codecov-io
Copy link

codecov-io commented Jun 16, 2017

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 45.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   60.22%   60.22%           
=======================================
  Files           1        1           
  Lines          88       88           
  Branches       22       22           
=======================================
  Hits           53       53           
  Misses         29       29           
  Partials        6        6
Impacted Files Coverage Δ
sgbackend/mail.py 60.22% <45.45%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476bfbe...e5f6fc8. Read the comment docs.

@pcraciunoiu
Copy link
Author

@elbuo8 any update on this? Anything you need me to do?

@andriisoldatenko
Copy link
Collaborator

Could you please add unit tests?

@pcraciunoiu
Copy link
Author

@andriisoldatenko do you have permissions to merge? I can look into tests.

I'm concerned because many people have forked this project, probably thinking it looks abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants