Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: possibility of adding asm configuration to mail object #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

danniehakan
Copy link

@danniehakan danniehakan commented Oct 6, 2017

ASM fields in /mail/send v3 endpoint support has been added

Resolves #72

@codecov-io
Copy link

codecov-io commented Oct 6, 2017

Codecov Report

Merging #73 into master will increase coverage by 2.75%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   65.38%   68.14%   +2.75%     
==========================================
  Files           1        1              
  Lines         104      113       +9     
  Branches       30       33       +3     
==========================================
+ Hits           68       77       +9     
  Misses         29       29              
  Partials        7        7
Impacted Files Coverage Δ
sgbackend/mail.py 68.14% <90.9%> (+2.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b784d5...d7be2ac. Read the comment docs.

@danniehakan
Copy link
Author

Get back if you want to merge this, because at this point I'm beyond this issue in my fork.

@andriisoldatenko
Copy link
Collaborator

@danniehakan Please resolve conflict and I'll merge it.

@danniehakan
Copy link
Author

I've resolved the conflicts.

@andriisoldatenko
Copy link
Collaborator

@danniehakan can you please add small description to documents.

@danniehakan
Copy link
Author

It seems like the build timed out upon dependency installation. It seems to be unrelated to this.

@henadzit
Copy link

@danniehakan @andriisoldatenko, is there anything that needs to be done before it can be merged? Thanks!

@janabimustafa
Copy link

@andriisoldatenko Hello! Would love to have this merged. If you run the build again I am sure it will pass

@dhakan
Copy link

dhakan commented Nov 6, 2019

Just stumbled upon this again. Am I supposed to do anything here? I'm not sure why the build failed, and I don't know if I'm able to re-run the build step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applying group data to Mail object
6 participants