Skip to content

Commit

Permalink
[Fix](Variant) implement some interface in ColumnNothing
Browse files Browse the repository at this point in the history
IColumnDummy implementation is not suitable for ColumnNothing in ColumnObject
  • Loading branch information
eldenmoon committed Sep 10, 2024
1 parent bf04eb2 commit 4b399f2
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions be/src/vec/columns/column_nothing.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,19 @@ class ColumnNothing final : public COWHelper<IColumnDummy, ColumnNothing> {

ColumnNothing(const ColumnNothing&) = default;

ColumnPtr permute(const Permutation& perm, size_t limit) const override {
return clone_dummy(limit ? std::min(s, limit) : s);
}
Field operator[](size_t) const override {
return {};
}
void get(size_t, Field& f) const override {
f = {};
}
void insert(const Field&) override {
++s;
}

public:
const char* get_family_name() const override { return "Nothing"; }
MutableColumnPtr clone_dummy(size_t s_) const override { return ColumnNothing::create(s_); }
Expand Down

0 comments on commit 4b399f2

Please sign in to comment.