Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @electerious,
I took a jab at implementing some sort of base URL support. Can you give this a test run and tell me what you think?
I wrote some documentation as well.
One downside of this implementation is that withACKEE_BASEURL=/ackee
the server listens onexample.com/ackee/
, but not atexample.com/ackee
. This is because the relative paths need the trailing/
(at least, I think so. Couldn't get it to work otherwise). It's not a breaking bug, and it's easily solved by configuring a http redirect from/ackee
to/ackee/
in your reverse proxy. Maybe we could include that redirect directly in server.js?The above is now fixed.