Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the maximum path length is sufficient #1091

Conversation

joeyates
Copy link

As indicated in the code comment, IDBBatchAtomicVFS's default for mxPathName is 64.
SQLite allocates memory for the file name length plus 8 bytes, so file names longer than 56 bytes cause SQLite open commands to fail.

N.B. This change alone is not sufficient to resolve the problem.

There is an underlying problem caused by a bug in wa-sqlite that causes mxPathName to be ignored. The fix is in PR 163.

@joeyates
Copy link
Author

The wa-sqlite PR has been merged

@joeyates
Copy link
Author

wa-sqlite release 0.9.13 includes this fix.

@KyleAMathews
Copy link
Contributor

👋 we've been working the last month on a rebuild of the Electric server over at a temporary repo https://github.com/electric-sql/electric-next/

You can read more about why we made the decision at https://next.electric-sql.com/about

We're really excited about all the new possibilities the new server brings and we hope you'll check it out soon and give us your feedback.

We're now moving the temporary repo back here. As part of that migration we're closing all the old issues and PRs. We really appreciate you taking the time to investigate and create this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants