Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electric,elixir-client): Write static version string to mix.exs prior to publishing #2180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(electric,elixir-client): Write static version string to mix.exs prior to publishing #2180

wants to merge 1 commit into from

Conversation

alco
Copy link
Member

@alco alco commented Dec 18, 2024

Fixes #2179

@alco alco requested a review from magnetised December 18, 2024 11:51
@icehaunter
Copy link
Contributor

I'm not against this approach, but in elixir-client it's solved just by including package.json in published filies. Maybe it's easier to just do that here too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetised magnetised Awaiting requested review from magnetised

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement/bug: electric version falls back to 0.0.0 when used as hex package
2 participants
@alco @icehaunter