Fix Mongolia parser, add thermal + battery support [Mostly complete, needs some work so if someone else wants to complete this please do] #7444
Conversation
|
Looks good from a first glance! There is a risk that unknown can contain other types than just hydro as we don't know if all of their production modes are actually reported properly for all plants. But I think this is a reasonable assumption to make given the available data. I can take a look at it later today and add the needed override values. Sadly other contributors can't edit existing PR, only EMaps members can. |
|
Thank you!
A small thing I didn't think of when working on this: I could also imagine
that 'dts' is just coal and not coal + oil, it might've been established at
some point but I don't remember.
|
github-actions
bot
added
the
zone config
| @@ -46,6 +49,9 @@ emissionFactors: | |||
| datetime: '2020-01-01' | |||
| source: IEA 2020; assumes 92.85% coal, 5.78%% oil, 1.37% hydro in unknown | |||
| value: 799.2 | |||
| - datetime: '2024-11-25' | |||
| source: IEA 2020; assumes 94.14% coal, 5.86% oil in unknown | |||
There was a problem hiding this comment.
This source also says IEA 2020 but has different values from two lines up, is that correct?
There was a problem hiding this comment.
Yes, basically I used the same source but simply removed hydro since that will now be reported on it's own.
VIKTORVAV99
requested review from
FelixDQ and
annaib00
and removed request for
VIKTORVAV99
| @@ -99,6 +101,7 @@ def fetch_production( | |||
| # 'unknown' consists of 92.8% coal, 5.8% oil and 1.4% hydro as per 2020; sources: IEA and IRENA statistics. | |||
| query_data["leftoverMW"] = round( | |||
| query_data["consumptionMW"] | |||
| - query_data["thermalMW"] | |||
| - query_data["importMW"] | |||
| - query_data["solarMW"] | |||
| - query_data["windMW"], | |||
There was a problem hiding this comment.
LGTM!
Just a quick question, should any usage/withdrawings from battery storage be included here?
Issue
See #5906
Description
Fixes the Mongolia parser by correcting a renamed field in the API, determining that 'Songino' stands for battery (#5906 (comment)). It also maps
tppto thermal.Still to be done:
tppproduction but on total unaccounted for production and therefore should include hydro).(I wrote this in the GitHub web editor hoping to give someone else a starting point for fixing this, if someone else can do the last steps that would be appreciated. May even be tagged 'help wanted'.)
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.