Pumping storage fix for CZ parser #7530
Open
+66
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
requested changes
Dec 11, 2024
| session: Session = Session(), | ||
| target_datetime: datetime | None = None, | ||
| logger: Logger = getLogger(__name__), | ||
| ) -> list: |
There was a problem hiding this comment.
This has the return type list.
| zone_key, | ||
| ) | ||
|
|
||
| return pumping_load_at_time_dict |
There was a problem hiding this comment.
But this is returning a dict.
Comment on lines
+174
to
+177
| for values in data_tag: | ||
| pumping_load_at_time_dict[values["date"]] = float(values["value1"]) - float( | ||
| values["value2"] | ||
| ) |
There was a problem hiding this comment.
This also contains type errors. Such as "__getitem__" method not defined on type "PageElement"
| storage.add_value(mode=generator, value=float(values[v]) * -1) | ||
| pumping_storage = float(values[v]) * -1 | ||
| if values["date"] in pumping_load_at_time: | ||
| pumping_storage += pumping_load_at_time[values["date"]] |
There was a problem hiding this comment.
Why are you summing things up here?
If there are multiple storage entries they should be looped over and add_value should be called on each of them as it handles summing up values of the same type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #5426
Description
Creates get_pumping_load function which fetches pumping load data from ceps.cz and computes the current load at each timestamp that is being used for pumping.
Modifies fetch_production to call get_pumping_load, whose dictionary is then used to add the amount of energy being stored to hydro at each timestamp.
Preview
The hydro storage values from fetch_production() showing the new positive values calculated from load_including_pumping-load
Double check
poetry run test_parser "zone_key"- I got the error marking ":( >2h from now !!!" but the original CZ parser code produces the exact same error locally. I tried to see if it was a time conversion issue but didn't have any luck locating the source of the issuepnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.