Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): update capacity in RO.yaml #7547

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mzaharie
Copy link
Contributor

Issue

Description

Add new link for capacities in Romania

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Dec 12, 2024
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR!

However there are some changes that has to be made to ensure it works with our existing systems.

@@ -9,45 +9,70 @@ capacity:
- datetime: '2023-01-01'
source: entsoe.eu
value: 118.0
- datetime: '2024-12-12'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the date the data was published or updated?

We would like the use the date it was updated to prevent any regressions if it's updated in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The web page states these are the numbers today -- https://anre.ro/puteri-instalate/

config/zones/RO.yaml Outdated Show resolved Hide resolved
config/zones/RO.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants