Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zones): Merge CA-NL-LB and CA-NL-NF into CA-NL #7582

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

VIKTORVAV99
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 commented Dec 19, 2024

Issue

The data source have these merged so we need to do so as well.
Part of: GMM-197

Description

Merges the zones so we can add a General Purpose Zone Estimation Model for it.

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser translations 🗣 python Pull requests that update Python code zone config Pull request or issue for zone configurations exchange config Pull request or issue for exchange configurations labels Dec 19, 2024
@jarek
Copy link
Collaborator

jarek commented Dec 24, 2024

Out of curiosity which data source do you have for it merged?

for reference, the split was done in #3092 but then I think the parser was never actually written, I guess because the data source doesn't give a lot of data

@VIKTORVAV99
Copy link
Member Author

Out of curiosity which data source do you have for it merged?

for reference, the split was done in #3092 but then I think the parser was never actually written, I guess because the data source doesn't give a lot of data

We will be using monthly data from https://www.cer-rec.gc.ca that will be processed into hourly values based on local weather patterns and sunset/sunrise. While not as accurate on a hourly level we've decided to do this for all the missing Canadian zones where we are missing data sources. If we can find better data sources for them in the future we will happily use those.

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) January 6, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exchange config Pull request or issue for exchange configurations parser python Pull requests that update Python code translations 🗣 zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants