Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf/fix: Remove trans component from RankingPanel.tsx #7647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VIKTORVAV99
Copy link
Member

Issue

A innocent little change introduced in #7568 caused our bundle size to increase by 7.3 kb and the subtitle to constantly re-render when the datetime changes.

Description

Switches back to using the t() function instead to fix this regression

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@VIKTORVAV99 VIKTORVAV99 added performance 🏎 techdebt Unpleasantness that does (or may in future) affect development labels Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@tonypls
Copy link
Collaborator

tonypls commented Jan 6, 2025

This was to create add the correct breakpoint, see image:
image

Is there another way we can break the line after "from" and remove the br?

@VIKTORVAV99
Copy link
Member Author

VIKTORVAV99 commented Jan 6, 2025

This was to create add the correct breakpoint, see image:

image

Is there another way we can break the line after "from" and remove the br?

Hmm I see, by looking at the documentation it don't look like it was intended to do that.

i18next does keep some html tags like <b> and <i>, I'll see if I can create a PR for <br> as well. Let's leave this open until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend 🎨 performance 🏎 techdebt Unpleasantness that does (or may in future) affect development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants