fix(parsers, MX): drop seldom occuring datapoints with an hour set to 25 #7696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parser
python
VIKTORVAV99
reviewed
Jan 6, 2025
Comment on lines
+151
to
+154
| # The hour column has been seen at least once (3rd Nov 2024) to include 1-25 | ||
| # hours rather than the expected 1-24, due to this, we are for now dropping | ||
| # such entries if they show up | ||
| df = df.drop(df[df["Hora"] == "25"].index) |
There was a problem hiding this comment.
How does this even happen...
Is it possible this is related to daylight savings?
There was a problem hiding this comment.
I considered that as well, but this was 3rd Nov, and I don't think it would change in November - also, and it seems MX hasn't had DST since 2022 or something like that.
There was a problem hiding this comment.
Then IDK what it can be but since it's not every day we should probably just get rid of that datapoint.
I don't even know where it would end up as our database is strictly 24 hours and not 25 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Possibly #7556, but I'm not sure - it could be something else. I found this issue though.
Description
It appears that sometimes the date / hour data returned for the PX production parser includes a 25th hour entry, instead of the expected 1-24. In such cases, we now drop that datapoint.
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.