Fix bugs with ladder filter feedback and highpass modes #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndonald2
force-pushed
the
ladder-fixes
branch
from
160eae4 to
0dd093c
Compare
Proper PBG compensation depends on using scaled drive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes minor bugs in the new ladder filter added in #200:
I messed up that part of the code in my original PR, I adapted it from before I made this fix and didn't catch it until just now.
Testing
Tested using same example code in #200 with all filter type options to verify expected sound and response. Before and after difference is stark - the filter was just not working correctly before in the HPF modes.
Demos / Example Code
See code from #200