Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 44.1kHz to SAI #438

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheSlowGrowth
Copy link
Contributor

Is this all that's needed to add support for 44.1kHz? It seems too simple, so I guess I'm missing something.

44.1kHz makes sense when sample playback from *.wav files is desired.

@stephenhensley
Copy link
Collaborator

Hahahaha, if only. Right?

Because of the SAI clock source this will still end up generating a 48kHz clock.

In order to add 44.1kHz (and the other related samplerates) we'll have to adjust the PLL for the clock.

I can't recall if the PLL (2?) is used exclusively for audio/ADCs at this point, but that's the goal. And then we can adjust the PLL/MCLK freq to target the desired 256fs speed.

Once something like that is set up, we could probably implement something that can hit pretty much any target samplerate with good accuracy.

@stephenhensley stephenhensley marked this pull request as draft June 20, 2023 20:18
@stephenhensley
Copy link
Collaborator

Hi @TheSlowGrowth

I'm starting a little bit of housekeeping, and just want to tidy up some stale PRs.

I've marked this as a draft for now. If you'd rather close it for the time being instead, that's also fine. It'll probably still be a little bit before we get around to reworking the clock tree, adding an API for adjusting the PLLs for the required frequency changes on our end unless someone else gets to it sooner.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants