Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add editorconfig file #537

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TheSlowGrowth
Copy link
Contributor

@TheSlowGrowth TheSlowGrowth commented Jul 19, 2022

This is a proposal to add an .editorconfig file that can automatically configure code editors to use the recommended settings for this repository.

  • Add .editorconfig file
  • Add editorconfig extension to the recommended VSCode extensions
  • Add a check to the style workflow that enforces the formatting
  • Format all relevant files to the editorconfig settings (mostly removing trailing spaces)

@TheSlowGrowth
Copy link
Contributor Author

okay, that github action is clearly not maintained anymore. I'll search for a replacement we can use. In the worst case, we could also choose to not verify the formatting on CI.

@TheSlowGrowth TheSlowGrowth force-pushed the feature/add-editorconfig-file branch 2 times, most recently from 3708d19 to c5d223c Compare July 19, 2022 17:04
@TheSlowGrowth
Copy link
Contributor Author

Okay, I removed the github action for now. There doesn't seem to be a readily available action that works :-(

@stephenhensley
Copy link
Collaborator

Side note -- holy cow, there was so much trailing white space in the comments!! 😱

@stephenhensley
Copy link
Collaborator

Hi @TheSlowGrowth

Sorry for the huge delay in getting to this one.
Last time I looked this over, I don't think I realized it was ready to review/merge due to the comments about the github action.

Happy to review/merge this if it's ready (looks like the conflicts are all fairly trivial atm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants