Remove WM8731 TODO comment #623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was reading the WM8731 audio codec setup code and I got confused by a comment which suggested Daisy always uses the codec with a 48kHz sample rate. After several hours of reading data sheets I figured out what is going on here: the WM8731 has built-in sample rate conversion and the nominal "48kHz" setting disables the built-in conversion. This commit updates the comment to explain what we are actually doing here.
|
Looks good, nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading the WM8731 audio codec setup code and I got confused by a comment which suggested Daisy always uses the codec with a 48kHz sample rate. After several hours of reading data sheets I figured out what is going on here: the WM8731 has built-in sample rate conversion and the nominal "48kHz" setting disables the built-in conversion.
This commit updates the comment to explain what we are actually doing here.