Replacing true
with ""
in *ARCHIVE_FINISH
directives
#648
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up a new project, CMake will check to make sure the compiler is working with the given toolchain. With the libDaisy toolchain file, this test produces a command line invocation of qcs as follows:
When invoked in bash,
true
is a no-op and not an issue. However, on Windows,true
doesn't exist, So this fails with the following message:This change removes the
true
invocation with an empty string, and the test will pass. This was also tested on bash with no regressions detected.