Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing true with "" in *ARCHIVE_FINISH directives #648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

metaphaseaudio
Copy link

When setting up a new project, CMake will check to make sure the compiler is working with the given toolchain. With the libDaisy toolchain file, this test produces a command line invocation of qcs as follows:

qcs libcmTC_a65c7.a  CMakeFiles/cmTC_a65c7.dir/testCCompiler.c.obj && true && cd .

When invoked in bash, true is a no-op and not an issue. However, on Windows, true doesn't exist, So this fails with the following message:

'true' is not recognized as an internal or external command

This change removes the true invocation with an empty string, and the test will pass. This was also tested on bash with no regressions detected.

When setting up a new project, CMake will check to make sure the
compiler is working with the given toolchain. With the libDaisy
toolchain file, this test produces a command line invocation of qcs as
follows:

```
qcs libcmTC_a65c7.a  CMakeFiles/cmTC_a65c7.dir/testCCompiler.c.obj && true && cd .
```

When invoked in bash, this is a no-op and not an issue. However, on
Windows, this fails with the following message:

```
'true' is not recognized as an internal or external command
```

This change removes the `true` invocation with an empty string, and the
test will pass.
@stellar-aria
Copy link
Contributor

Just a heads up that this is addressed in #615 (and was the start of it, in fact).

@metaphaseaudio
Copy link
Author

I'm happy to cede to your PR. It's been a while since there's been motion there, is there anything I can do to help push that to be merged?

@stellar-aria
Copy link
Contributor

@stephenhensley said on Discord it was going to be merged sometime in the coming week(s) as part of a v8.0.0 tag, so I don't think there's anything for us to do, just the admins.

@stephenhensley
Copy link
Collaborator

confirmed that I should be getting around to #615 in the next few days. Hoping to have things in place for a v8 release on Friday ❤️

Feel free to close this PR unless you feel that there's any crossover that should be preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants