Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOMs and negative inputs #66

Closed
wants to merge 30 commits into from

Conversation

CorvusPrudens
Copy link
Collaborator

@CorvusPrudens CorvusPrudens commented Nov 22, 2021

This PR adds a SOM field to the json for targeting a specific SOM (right now either seed or patch_sm).

It also permits negative inputs when using input_min and input_max fields in an input description, e.g.:

{
  "inputs": {
    ...
    "cv5": {
      "input_min": -1,
      "input_max": 1,
      "code": "hardware.GetAdcValue(daisy::patch_sm::CV_5);"
    },
    ...
  }
}

This adjusts the scaling Oopsy does to factor in the different input range, preserving the expected behavior of the @max and @min param attributes. This addresses #60.

@CorvusPrudens CorvusPrudens mentioned this pull request Mar 29, 2022
@stephenhensley
Copy link
Collaborator

closing as this is handled in #69

@CorvusPrudens CorvusPrudens mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants