-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert to typescript and upgrade Node.js versions #178
Conversation
542a9ed
to
95fd3bc
Compare
BREAKING CHANGE: The exported API is now a named export `createDMG` and the `debug` option has been removed.
95fd3bc
to
eec8137
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
===========================================
- Coverage 75.43% 44.64% -30.80%
===========================================
Files 1 1
Lines 57 56 -1
Branches 0 18 +18
===========================================
- Hits 43 25 -18
- Misses 14 19 +5
- Partials 0 12 +12 ☔ View full report in Codecov by Sentry. |
I'm looking forward to have it merged |
|
||
if (args.help || args.h || !options.appPath || !options.name) { | ||
console.error(usage); | ||
process.exit(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we shouldn't change this in a TS refactor but this seems like an odd choice, —help
usually ends in code 0
Converts to typescript so that forge can just import the options type instead of duplicating it.
This is a breaking change per the commit message, the export is now a named export
createDMG
and thedebug
option has been removed because it makes no sense.