Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert to typescript and upgrade Node.js versions #178

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Oct 27, 2022

Converts to typescript so that forge can just import the options type instead of duplicating it.

This is a breaking change per the commit message, the export is now a named export createDMG and the debug option has been removed because it makes no sense.

@MarshallOfSound MarshallOfSound requested a review from a team October 27, 2022 09:46
@MarshallOfSound MarshallOfSound force-pushed the ts-installer-dmg branch 3 times, most recently from 542a9ed to 95fd3bc Compare October 27, 2022 09:59
BREAKING CHANGE: The exported API is now a named export `createDMG` and the `debug` option has been removed.
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Attention: Patch coverage is 44.64286% with 31 lines in your changes missing coverage. Please review.

Project coverage is 44.64%. Comparing base (ddc6db7) to head (eec8137).
Report is 2 commits behind head on main.

Current head eec8137 differs from pull request most recent head 001ed46

Please upload reports for the commit 001ed46 to get more accurate results.

Files Patch % Lines
src/index.ts 44.64% 19 Missing and 12 partials ⚠️

❗ There is a different number of reports uploaded between BASE (ddc6db7) and HEAD (eec8137). Click for more details.

HEAD has 3 uploads less than BASE | Flag | BASE (ddc6db7) | HEAD (eec8137) | |------|------|------| ||6|3|
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #178       +/-   ##
===========================================
- Coverage   75.43%   44.64%   -30.80%     
===========================================
  Files           1        1               
  Lines          57       56        -1     
  Branches        0       18       +18     
===========================================
- Hits           43       25       -18     
- Misses         14       19        +5     
- Partials        0       12       +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@mahnunchik
Copy link

I'm looking forward to have it merged

@erickzhao erickzhao self-requested a review June 26, 2024 18:44
@erickzhao erickzhao self-assigned this Jun 26, 2024
@erickzhao erickzhao changed the title refactor: convert to typescript refactor: convert to typescript and upgrade Node.js versions Jun 26, 2024

if (args.help || args.h || !options.appPath || !options.name) {
console.error(usage);
process.exit(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we shouldn't change this in a TS refactor but this seems like an odd choice, —help usually ends in code 0

@felixrieseberg felixrieseberg merged commit 7953a8d into main Jul 2, 2024
4 checks passed
@felixrieseberg felixrieseberg deleted the ts-installer-dmg branch July 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants