fix: depend on pulseaudio, not libpulse0 (#35)

Electron has a dependency on libasound2. If you need pulseaudio support, you'll need the pulseaudio package anyway. This has the side benefit of also requiring the libasound2 package.
electron-userland · Jun 20, 2019 · f6eed8e · f6eed8e
1 parent c60ce64
commit f6eed8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/yaml.js b/src/yaml.js
@@ -35,7 +35,7 @@ const DEPENDENCY_MAP = {
 
 const FEATURES = {
   audio: {
-    packages: ['libpulse0'],
+    packages: ['pulseaudio'],
     plugs: ['pulseaudio']
   },
   alsa: {

diff --git a/test/yaml.js b/test/yaml.js
@@ -63,13 +63,13 @@ test('set feature on app', async t => {
     }
   }
   const snapcraftYaml = await createYaml(t, userDefined)
-  util.assertIncludes(t, snapcraftYaml.parts.electronAppName['stage-packages'], 'libpulse0', 'libpulse0 is in stage-packages')
+  util.assertIncludes(t, snapcraftYaml.parts.electronAppName['stage-packages'], 'pulseaudio', 'pulseaudio is in stage-packages')
   util.assertIncludes(t, snapcraftYaml.apps.electronAppName.plugs, 'pulseaudio', 'pulseaudio is in app plugs')
 })
 
 test('setting both audio and alsa prefers alsa', async t => {
   const { apps, parts } = await createYaml(t, { name: 'electronAppName', features: { 'audio': true, 'alsa': true } })
-  util.assertNotIncludes(t, parts.electronAppName['stage-packages'], 'libpulse0', 'libpulse0 is not in stage-packages')
+  util.assertNotIncludes(t, parts.electronAppName['stage-packages'], 'pulseaudio', 'pulseaudio is not in stage-packages')
   util.assertNotIncludes(t, apps.electronAppName.plugs, 'pulseaudio', 'pulseaudio is not in app plugs')
   util.assertIncludes(t, parts.electronAppName['stage-packages'], 'libasound2', 'libasound2 is in stage-packages')
   util.assertIncludes(t, apps.electronAppName.plugs, 'alsa', 'alsa is in app plugs')