Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle missing local Electron.app #1530

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

codebytere
Copy link
Member

Closes #1529

Handles the case where a local Electron executable has moved or been deleted.

Before:

Screenshot 2024-01-13 at 10 17 04 AM

After:

Screenshot 2024-01-13 at 10 29 54 AM

@codebytere codebytere requested a review from a team as a code owner January 13, 2024 09:34
@codebytere codebytere force-pushed the missing-local-picker branch from ef54ccf to 62400ac Compare January 13, 2024 09:35
@codebytere codebytere changed the title Missing local picker fix: handle missing local Electron.app Jan 13, 2024
@codebytere codebytere force-pushed the missing-local-picker branch from 62400ac to 8e10339 Compare January 13, 2024 09:44
@coveralls
Copy link

coveralls commented Jan 13, 2024

Coverage Status

coverage: 87.004% (-0.1%) from 87.103%
when pulling 4150137 on missing-local-picker
into fe192ae on main.

src/renderer/components/version-select.tsx Outdated Show resolved Hide resolved
@codebytere codebytere merged commit 18b8c95 into main Jan 15, 2024
9 checks passed
@codebytere codebytere deleted the missing-local-picker branch January 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle missing local Electron.app
4 participants