Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump to Electron 29.1.4 #1550

Merged
merged 2 commits into from
Mar 20, 2024
Merged

build: bump to Electron 29.1.4 #1550

merged 2 commits into from
Mar 20, 2024

Conversation

VerteDinde
Copy link
Member

This PR bumps Fiddle to use Electron 29.0.1

@VerteDinde VerteDinde requested review from codebytere and a team as code owners February 22, 2024 19:45
@coveralls
Copy link

coveralls commented Feb 22, 2024 •
edited
Loading

Coverage Status

coverage: 87.361% (+0.1%) from 87.245%
when pulling 0c0534c on bump-e29
into 4bf7ed9 on main.

dsanders11
dsanders11 requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until the bug preventing running is fixed.

@dsanders11 dsanders11 changed the title build: bump to Electron 29.0.1 build: bump to Electron 29.1.4 Mar 20, 2024
dsanders11
dsanders11 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this to bump to the latest stable release and include the fix in @electron/fiddle-core needed for E28+. 👍

@dsanders11 dsanders11 merged commit 92b2428 into main Mar 20, 2024
10 checks passed
@dsanders11 dsanders11 deleted the bump-e29 branch March 20, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VerteDinde @coveralls @dsanders11