Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use async showOpenDialog #1584

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: use async showOpenDialog #1584

merged 1 commit into from
Apr 26, 2024

Conversation

dsanders11
Copy link
Member

The original issue behind using showOpenDialogSync, #553, no longer repros. showOpenDialogSync doesn't play nice with multiple Fiddle windows as it will block the UI on other windows.

@dsanders11 dsanders11 requested a review from erickzhao April 25, 2024 23:13
@dsanders11 dsanders11 marked this pull request as ready for review April 25, 2024 23:15
@dsanders11 dsanders11 requested review from codebytere and a team as code owners April 25, 2024 23:15
@coveralls
Copy link

Coverage Status

coverage: 87.472% (+0.1%) from 87.361%
when pulling 1e0f24d on fix/open-dialog-async
into 6c19d58 on main.

erickzhao
erickzhao approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsanders11 dsanders11 merged commit 6a1c886 into main Apr 26, 2024
10 checks passed
@dsanders11 dsanders11 deleted the fix/open-dialog-async branch April 26, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsanders11 @coveralls @codebytere @BlackHole1 @erickzhao