chore: remove cross-spawn from deps #3817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
approved these changes
Jan 23, 2025
erickzhao
force-pushed
the
no-cross-spawn
branch
from
3abbe09 to
6f621a9
Compare
|
Wait I'm tripping, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit sloppy addressing #3802 (comment). This cleans up all references to
cross-spawn.Edit: It turns out that we still use
cross-spawnin MakerAppX, but only an undocumented util function that isn't part of its public API.Instead, I've copied that function over so that we don't depend on a function that could in theory be refactored out in the future.