Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to GHA #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 0 additions & 96 deletions .circleci/config.yml

This file was deleted.

35 changes: 35 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Release

on:
push:
branches:
- main

jobs:
test:
uses: ./.github/workflows/test.yml

release:
name: Release
runs-on: ubuntu-latest
needs: test
environment: npm
permissions:
id-token: write # for CFA and npm provenance
steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: Setup Node.js
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: 20.x
cache: 'yarn'
- name: Install
run: yarn install --frozen-lockfile
- uses: continuousauth/action@4e8a2573eeb706f6d7300d6a9f3ca6322740b72d # v1.0.5
with:
project-id: ${{ secrets.CFA_PROJECT_ID }}
secret: ${{ secrets.CFA_SECRET }}
npm-token: ${{ secrets.NPM_TOKEN }}
62 changes: 62 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: Test

on:
pull_request:
branches:
- main
schedule:
- cron: '0 22 * * 3'
workflow_call:

permissions:
contents: read

jobs:
test:
name: Test
strategy:
matrix:
node-version:
- '20.9'
- '18.17'
- '16.20'
- '14.21'
os:
- macos-latest
- ubuntu-latest
- windows-latest
runs-on: "${{ matrix.os }}"
steps:
# rc-edit.exe does not support arm64
- name: Install Rosetta
if: ${{ matrix.os == 'macos-latest' }}
run: /usr/sbin/softwareupdate --install-rosetta --agree-to-license
- name: Homebrew Cache
if: ${{ matrix.os == 'macos-latest' }}
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
with:
path: /usr/local/Homebrew
key: v1-brew-cache-${{ matrix.os }}
- name: Install OS Dependencies (Linux)
if: ${{ matrix.os == 'ubuntu-latest' }}
run: |
sudo dpkg --add-architecture i386
sudo apt-get update
sudo apt-get install --no-install-recommends -y wine64 wine32 wine
- name: Install OS Dependencies (macOS)
if: ${{ matrix.os == 'macos-latest' }}
run: |
brew install --cask xquartz
brew install --cask --no-quarantine wine-stable
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Setup Node.js
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: "${{ matrix.node-version }}"
cache: 'yarn'
architecture: ${{ matrix.node-version == '14.21' && 'x64' || env.RUNNER_ARCH }}
- name: Install
run: yarn install --frozen-lockfile
- name: Test
run: yarn test
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# node-rcedit

[![CircleCI build status](https://circleci.com/gh/electron/node-rcedit/tree/main.svg?style=shield)](https://circleci.com/gh/electron/node-rcedit/tree/main)
[![Test](https://github.com/electron/node-rcedit/actions/workflows/test.yml/badge.svg)](https://github.com/electron/node-rcedit/actions/workflows/test.yml)
[![NPM package](https://img.shields.io/npm/v/rcedit)](https://npm.im/rcedit)

Node module to edit resources of Windows executables.
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
"engines": {
"node": ">= 14.0.0"
},
"publishConfig": {
"provenance": true
},
"dependencies": {
"cross-spawn-windows-exe": "^1.1.0"
},
Expand Down
2 changes: 1 addition & 1 deletion test/rcedit-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function assertRceditError (exePath, options, messages) {
}

describe('async rcedit(exePath, options)', function () {
this.timeout(90000)
this.timeout(1200000)

let exePath = null
let tempPath = null
Expand Down
Loading