fix: remove build/node_gyp_bins if it exists #1025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
reviewed
Aug 1, 2022
|
@malept Definitely - I pushed this up as a draft first to make sure it passed CI, looking at how to best test this now |
|
Whoops, I missed the draft part. Sorry about that. |
MarshallOfSound
requested changes
Aug 1, 2022
There was a problem hiding this comment.
Hot take, this can go here, but I think it probably belongs in some kind of default ignore list in packager 🤔
Can we also potentially follow-up upstream with a change that moves this directory outside of node_modules. I don't see a technical need for the node_gyp_bins folder to be generated for every module or in the actual module folder itself (vs just being in a tmpdir)
|
@MarshallOfSound Yeah, I think that's a fair take! 🙂 I'll close this one and move the work over to packager. Will also file an issue upstream with node-gyp itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1024
In node-gyp v9.0.0, node-gyp adds a python symlink for older versions of python. This symlink is added to a
node_gyp_bins/python3directory within the build directory, which electron-rebuild then tries to rebuild. This PR removes thenode_gyp_binsdirectory once the node gyp module has finished rebuilding.