refactor: improve branch support logic #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
reviewed
Aug 19, 2024
src/index.ts
Outdated
| ); | ||
|
|
||
| if (!branch.trim()) continue; |
There was a problem hiding this comment.
Agree that the trim() call is redundant after map ((b) => b.trim()), but do we need to still check whether branch is empty? Or add a .filter() after .map() to remove empty strings?
codebytere
force-pushed
the
cleanup-supported-logic
branch
from
9fe38a7
to
c833283
Compare
jkleinsc
requested changes
Aug 20, 2024
Comment on lines
+569
to
+583
| try { | ||
| await context.octokit.repos.getBranch(context.repo({ branch })); | ||
| } catch (err) { | ||
| robot.log( | ||
| `${branch} does not exist - no backport will be initiated`, | ||
| ); | ||
| await context.octokit.issues.createComment( | ||
| context.repo({ | ||
| body: `Provided branch \`${branch}\` does not appear to exist.`, | ||
| issue_number: issue.number, | ||
| }), | ||
| ); | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why is this block moved under the section flagged by NO_EOL_SUPPORT?
There was a problem hiding this comment.
getSupportedBranches itself checks branch existence - so in moving it down we save a redundant check in the case the variable is set.
it moves the conditional down, but not inside the check - if |
jkleinsc
approved these changes
Aug 21, 2024
codebytere
force-pushed
the
cleanup-supported-logic
branch
from
c833283
to
54c81af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secondary to #300
Cleans up some comment-initiated backport logic