-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modale au clic sur un créneau de la page planning #1122
Merged
njean42
merged 4 commits into
elefan-grenoble:master
from
njean42:1121-modale-pour-les-créneaux-sur-la-page-planning
Nov 9, 2024
The head ref may contain hidden characters: "1121-modale-pour-les-cr\u00E9neaux-sur-la-page-planning"
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e83ae61
first shot at a modal for buckets on the /schedule page
njean42 aea4c3a
S'assurer que les 'form's sont définies avant de les afficher (mode a…
njean42 0a0a596
Ajout de la <div class="modal-content"> pour avoir l'espace blanc aut…
njean42 1a1ddce
Conditionner l'affichage des boutons "Envoyer un email" et "Éditer" (…
njean42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 6 additions & 1 deletion
7
app/Resources/views/admin/member/_partial/member_or_user_link.html.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,16 @@ | ||
{% if (display_names ?? true) %} | ||
{% set display_names = display_name_shifters %} | ||
{% endif %} | ||
{% set target_blank = target_blank ?? false %} | ||
|
||
{% if user %} | ||
{% if user and display_names %} | ||
{% if user.beneficiary %} | ||
<a href="{{ path("member_show", { 'member_number': user.beneficiary.membership.memberNumber }) }}" {% if target_blank %}target="_blank"{% endif %}> | ||
{{ user.beneficiary }} | ||
</a> | ||
{% else %} | ||
{{ user }} | ||
{% endif %} | ||
{% else %} | ||
quelqu'un⋅e | ||
{% endif %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne sais pas trop ce que sont les
shift_free_forms
, et donc je ne sais pas si vérifier leur présence est la meilleure façon de faire ici.Idem pour les autres
if … is defined
plus bas :shift_book_forms
bucket_shift_add_form
bucket_lock_unlock_form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ce ne sont pas des free_form, mais des shift_free forms ;) Le créneaux libres sont une fonctionnalités offerte par Elefan que l'on n'utilise pas nous. Une variable existe pour activer la fonctionnalité.