Exemptions : filtre basique sur la liste des membres exemptés #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
petitalb
reviewed
Jan 30, 2023
|
|
||
| if ($res['form']->isSubmitted() && $res['form']->isValid()) { | ||
| $res["shiftExemption"] = $res["form"]->get("shiftExemption")->getData(); | ||
| } |
There was a problem hiding this comment.
Faire un $res["filter"]["shiftExemption"]
petitalb
reviewed
Jan 30, 2023
| * @Security("has_role('ROLE_USER_MANAGER')") | ||
| */ | ||
| public function indexAction(Request $request) | ||
| { | ||
| $em = $this->getDoctrine()->getManager(); | ||
| $filter = $this->filterFormFactory($request); | ||
| $findByFilter = array(); |
There was a problem hiding this comment.
Suggested change
| $findByFilter = array(); | |
| $findByFilter = $filter['filter']; |
cf mon autre commentaire
There was a problem hiding this comment.
ca ne marche pas 🤔
je vais laisser tel quel, je me suis inspiré des filter form existants sur JobController & PeriodController, tu peux proposer une PR qui refactore tous ces filtres ?
et plus généralement, je ne suis pas fan du code nécessaire pour ces filterForm (on devrait utiliser la méthode GET + j'ai l'impression que c'est très verbeux avec ces if partout...)
petitalb
reviewed
Jan 30, 2023
|
|
||
| if($filter["shiftExemption"]) { | ||
| $findByFilter["shiftExemption"] = $filter["shiftExemption"]; | ||
| } |
There was a problem hiding this comment.
A supprimer si le filtre est déjà fait au dessus.
cf. Mes autre commentaires
petitalb
approved these changes
Jan 30, 2023
raphodn
force-pushed
the
raphodn/membership-shift-exemption-filters
branch
from
ce274be
to
18c2fda
Compare
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Mar 28, 2023
…-grenoble#726) * Cleanup a bit the template * Add ShiftExemption.created_at. Add mapping for ManyToOne * Simple filter form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Modèle
MembershipShiftExemption:inversedByModèle
ShiftExemption:OneToMany(inverse duManyToOnedu modèle MembershipShiftExemption)createdAtCapture d'écran