Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: infra refresh #28

Closed
wants to merge 1 commit into from
Closed

chore: infra refresh #28

wants to merge 1 commit into from

Conversation

barak007
Copy link
Contributor

As a starter for #27

This PR move all unit test to work from .ts. I fixed all the type issues* that was uncovered, like in the usage of phasor and train. I also show there a more compact way to type the elements overloaded api. In order to do so I had to export RenderDelegate_t and I have one place that I used as any.

What else in here:

  • actually use npm workspace (not just lerna)
  • move to single tsconfig and single devDependencies in root package.json (didn't upgraded yet)
  • fix type issue with the createRef function

I tried to keep it small. please review that the flow you used to work with still works.
My IDE formatted some files...I plan to run prettier on all files anyhow but if you don't like that let me know I will make the effort to keep same formatting.

@barak007
Copy link
Contributor Author

barak007 commented Oct 2, 2023

@nick-thompson I'm pinging because I wanted to do more work on cleanup infra. let me know what's up. I don't want to advance without any signal of approval/review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants