Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 8x8 Presence icons. #126

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add the 8x8 Presence icons. #126

merged 1 commit into from
Nov 19, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 19, 2024

@robintown @jmartinesp Just want to double check you're both happy with how these are added to Web & Android.

(Seems unlikely we'll use these on mobile any time soon, so as long as the compiler/linter is happy for Android I guess)

@pixlwave pixlwave requested a review from a team as a code owner November 19, 2024 16:07
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the web output looks reasonable to me

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look fine on Android.

@pixlwave
Copy link
Member Author

Super, thanks both!

@pixlwave pixlwave merged commit 3adf924 into main Nov 19, 2024
3 checks passed
@pixlwave pixlwave deleted the doug/presence-icons branch November 19, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants