Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTD posthog reporting add more properties to captured event #8780

Merged
merged 11 commits into from
Apr 2, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Mar 14, 2024

Fixes #8779

Refactored the DecryptionFailureTracker so that it can report late decryption and permanent decryptions errors.

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr changed the title Valere/utd posthog more properties UTD posthog reporting add more properties to captured event Mar 14, 2024
@BillCarsonFr BillCarsonFr force-pushed the valere/utd_posthog_more_properties branch from b88bc98 to 4d04b27 Compare March 27, 2024 09:49
@BillCarsonFr BillCarsonFr marked this pull request as ready for review March 27, 2024 10:31
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one problem to fix, else it's all good to me.

// now remove from tracked
trackedEventsMap.remove(decryptionFailure.failedEventId)
// mark as already reported
alreadyReported.add(decryptionFailure.failedEventId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alreadyReported does not seem to be read.
It was used to filter the Events previously (line 140 in previous version)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch. I fixed the unit test that was not correctly testing that

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Apr 2, 2024
@BillCarsonFr BillCarsonFr merged commit 0f3ff2e into develop Apr 2, 2024
11 of 12 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/utd_posthog_more_properties branch April 2, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto | Add more properties to unable to decrypt Posthog events to allow more filtering
2 participants