Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sending user mentions, always send the user id as the fallback text #8847

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Make sure the rich text editor and the markdown one both send mentions with the user id as the fallback text for the permalink.

Motivation and context

Sending the user's display name can lead to other clients rendering outdated names or incorrect ones, so we'd rather fall back to the user id.

Tests

Send user mentions with both the RTE enabled and disabled, check the formatted body contains user id as the link's fallback text.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

Copy link

sonarcloud bot commented Jun 19, 2024

@jmartinesp jmartinesp marked this pull request as ready for review June 20, 2024 07:44
@jmartinesp jmartinesp requested review from a team and bmarty and removed request for a team June 20, 2024 07:44
@jmartinesp jmartinesp merged commit 4d27c84 into develop Jun 21, 2024
17 checks passed
@jmartinesp jmartinesp deleted the fix/jme/send-mentions-using-user-id-as-text branch June 21, 2024 10:33
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants