Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fga/authenticated media #8868

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jul 18, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Support for https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/3916-authentication-for-media.md

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty self-requested a review July 19, 2024 08:04
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first comments, I am still testing the feature.

@ElementBot
Copy link

ElementBot commented Jul 19, 2024

Warnings
⚠️

matrix-sdk-android/build.gradle#L164 - A newer version of net.java.dev.jna:jna than 5.13.0 is available: 5.14.0

⚠️

matrix-sdk-android/build.gradle#L164 - A newer version of net.java.dev.jna:jna than 5.13.0 is available: 5.14.0

Generated by 🚫 dangerJS against 59f3c6e

@ganfra ganfra requested a review from bmarty July 19, 2024 12:12
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@ganfra ganfra enabled auto-merge July 19, 2024 12:18
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ganfra ganfra disabled auto-merge July 19, 2024 14:30
@ganfra ganfra merged commit 95e1bcb into develop Jul 19, 2024
13 of 15 checks passed
@ganfra ganfra deleted the feature/fga/authenticated_media branch July 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants