-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crypto): Add support for verification violation warnings #8933
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@@ -58,7 +58,7 @@ internal class RustCrossSigningService @Inject constructor( | |||
* Checks that my trusted user key has signed the other user UserKey | |||
*/ | |||
override suspend fun checkUserTrust(otherUserId: String): UserTrustResult { | |||
val identity = olmMachine.getIdentity(olmMachine.userId()) | |||
val identity = olmMachine.getIdentity(otherUserId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Hopefully this code is only used in test with otherUserId
different than the current user. Else I guess we would have detected the problem faster.
Type of change
Fixes https://github.com/element-hq/crypto-internal/issues/384
Content
Requires a bump of crypto sdk in order to have the needed bindings matrix-org/matrix-rust-sdk#4105
Now that matrix-org/matrix-rust-sdk#1129 is fixed we can add back support for identity requirement violation notification. There was an existing test that was disabled, it is re-enabled now.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist