Test a few React components #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had experimented with turning this off in order to improve test performance, and apparently that ended up being merged. Now if we're to do component testing, we'll be changing things globally on the document, so isolation is very much necessary.
This patch release fixes a bug where tooltips would label non-interactive triggers in an inaccessible way.
toger5
reviewed
Sep 9, 2024
src/tile/SpotlightTile.test.tsx
Outdated
Comment on lines
52
to
55
| expect(await axe(container)).toHaveNoViolations(); | ||
| // Name should be visible | ||
| screen.getByText("Alice"); | ||
| }, |
There was a problem hiding this comment.
We could add a lot more expectations here:
- avatar url
- expanded
- indicators
...
There was a problem hiding this comment.
Right, I've added some more expectations now. I wasn't able to test the specific avatar URL, as that requires a full Matrix client setup, and the indicators are (intentionally, IIRC?) excluded from the accessibility tree. But, there were still some useful things to test, and I actually caught a couple more accessibility issues this way!
Catching two accessibility issues along the way: we were putting the wrong accessible labels on the 'expand' button, and even the off-screen pages of the spotlight tile were being exposed to accessibility technologies rather than hidden.
robintown
force-pushed
the
test-components
branch
from
fb6f2b8
to
d6985e0
Compare
robintown
force-pushed
the
test-components
branch
from
ee42f64
to
2fe8095
Compare
robintown
force-pushed
the
test-components
branch
from
2fe8095
to
e8278b4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since so much of this code base is made up React components, we do need to test them, and I wanted to see how easy it would be to get some automated accessibility tests with axe up and running. Along the way I discovered the reason why we were seeing funny errors in our tests (it was because I had turned off Vitest's test isolation option), and the tests I wrote also caught a real accessibility issue in Compound Web.