Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump js sdk to a branch supporting the state fix msc4222 changes and local-echo #2765

Closed
wants to merge 4 commits into from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Nov 12, 2024

No description provided.

@@ -87,7 +87,7 @@
"livekit-client": "^2.5.7",
"lodash": "^4.17.21",
"loglevel": "^1.9.1",
"matrix-js-sdk": "matrix-org/matrix-js-sdk#8e9a04cdec0f88fc876bbbf406db55b0677f005d",
"matrix-js-sdk": "matrix-org/matrix-js-sdk#0098c1a37d33123db5e5c54c6292a9cca7a87ca5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop my change that just landed too :) #2764

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. otherwise its not really testable right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not merge this for now but use the netlify version to test it
(so we have the save version on develop/livekit branch)

@toger5
Copy link
Contributor Author

toger5 commented Nov 13, 2024

We can close this since we did those changes as part of: #2767

We will move them over to the LK branch once they are merged into the js-sdk

@toger5 toger5 closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants