Introduce intent URL param and make it change the default lobby behaviour #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
changed the title
hughns
force-pushed
the
hughns/url-intent-param
branch
from
24ea34c to
5769ead
Compare
|
sounds like a good plan |
hughns
force-pushed
the
hughns/url-intent-param
branch
from
5769ead to
c7767e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: if the user is starting a call in widget mode then we should take them straight into the call rather than the lobby.
Otherwise, the widget host will have sent the call notify (which will have rung other people) but the person who started the call not actually joined yet... which is worked around in EW/ED at the moment.
Best viewed without whitespace changes.