Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user that their camera is starting in Lobby #2869

Open
wants to merge 14 commits into
base: livekit
Choose a base branch
from

Conversation

hughns
Copy link
Member

@hughns hughns commented Dec 4, 2024

Instead of just showing a grey box.

image

n.b. it is expected that this will be visible for a second or so whilst the browser and OS set up access to the camera.

Instead of just showing a grey box.
@fkwp
Copy link
Contributor

fkwp commented Dec 5, 2024

From internal discussion: I think text sounds apologetic. Maybe we can have a little spinner instead?

@americanrefugee
Copy link

Maybe show the avatar of the room you're about to join. Also consider adding a small spinner icon next to / above the message "Camera is starting".

@toger5
Copy link
Contributor

toger5 commented Dec 5, 2024

Toggling the camera in the lobby it now looks like the avatar is appearing disappearing which i think is very nice feedback to switch from muted -> video.
I think putting a spinner in the center of the previous avatar would look really good.

@americanrefugee
Copy link

americanrefugee commented Dec 5, 2024

How about this?

Loading video

Also, I changed my mind. The avatar should be YOUR avatar, not the room.

  • The room avatar is already in the header
  • The lobby is a preview of you, not the call

@toger5
Copy link
Contributor

toger5 commented Dec 5, 2024

@americanrefugee does it look better with the greyed out image?
I think just the loader and the label would be enough?

@americanrefugee
Copy link

@americanrefugee does it look better with the greyed out image? I think just the loader and the label would be enough?

Yes, it should be grayed out (50% opacity). Otherwise it will hard/impossible to see the spinner against the image - especially if the user avatar is light/white.

@hughns
Copy link
Member Author

hughns commented Dec 6, 2024

Benchmarking other applications:

Meet is showing the "Camera is starting" label:
image

Teams just goes to a grey tile until the video loads (a bit like what we have now):
image

Zoom doesn't provide feedback in the video tile (it continues to show the avatar), but has three states on the video button:

Off: image

Turning on: it's a grey intermediate version

On: image

@hughns hughns changed the title Inform user that their camera is starting Inform user that their camera is starting in Lobby Dec 6, 2024
@hughns
Copy link
Member Author

hughns commented Dec 6, 2024

The avatar is currently so large that you can't fit text below it at most resolutions.

The colour in this is text-secondary with space-10x below the top:

image

I will try a spinner on top of the avatar next.

@hughns
Copy link
Member Author

hughns commented Dec 6, 2024

It now looks like this which is an approximation of comments above:

image

@hughns hughns removed the X-Needs-Product More input needed from the Product team label Dec 10, 2024
@fkwp
Copy link
Contributor

fkwp commented Dec 10, 2024

fine for me

src/Avatar.module.css Outdated Show resolved Hide resolved
src/room/VideoPreview.tsx Outdated Show resolved Hide resolved
src/Avatar.tsx Outdated Show resolved Hide resolved
@robintown robintown removed the X-Needs-Design May require input from the design team label Dec 10, 2024
@hughns
Copy link
Member Author

hughns commented Dec 11, 2024

I've done a refactor based on @robintown's feedback. My intention is that the design will be used within a call as well. But this will go in another PR.

@hughns hughns requested a review from robintown December 11, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants