-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inform user that their camera is starting in Lobby #2869
base: livekit
Are you sure you want to change the base?
Conversation
Instead of just showing a grey box.
From internal discussion: I think text sounds apologetic. Maybe we can have a little spinner instead? |
Maybe show the avatar of the room you're about to join. Also consider adding a small spinner icon next to / above the message "Camera is starting". |
Toggling the camera in the lobby it now looks like the avatar is appearing disappearing which i think is very nice feedback to switch from muted -> video. |
Also, I changed my mind. The avatar should be YOUR avatar, not the room.
|
@americanrefugee does it look better with the greyed out image? |
Yes, it should be grayed out (50% opacity). Otherwise it will hard/impossible to see the spinner against the image - especially if the user avatar is light/white. |
fine for me |
I've done a refactor based on @robintown's feedback. My intention is that the design will be used within a call as well. But this will go in another PR. |
Instead of just showing a grey box.
n.b. it is expected that this will be visible for a second or so whilst the browser and OS set up access to the camera.