Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add autoformat and lint for ts/tsx files #1294

Closed
wants to merge 1 commit into from

Conversation

Palid
Copy link

@Palid Palid commented Oct 26, 2023

Implementation of autoformatting&autolinting on precommit hook.

Solves element-hq/element-web#18230 (4/3) (😆)


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@Palid Palid requested review from a team as code owners October 26, 2023 13:09
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Oct 26, 2023
@@ -0,0 +1,3 @@
{
"*.(ts|tsx)": ["eslint --fix", "prettier --write"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this will work quite right as we use a different eslintrc file depending on if the file is in src, test or scripts

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dbkr
Copy link
Member

dbkr commented Sep 9, 2024

Cleaning this one up as it seems inactive: let's re-open if anyone want to drive it.

@dbkr dbkr closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants