Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix can't show chinese on mac platform app menu. #304

Closed
wants to merge 1 commit into from

Conversation

chengfang0911
Copy link

@chengfang0911 chengfang0911 commented Jan 17, 2022


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@chengfang0911 chengfang0911 requested a review from a team as a code owner January 17, 2022 14:06
@chengfang0911
Copy link
Author

on mac platform just as Edit Undo don't translate because fetchTranslationJson parameter is zh-hans.json but not zh_Hans.json.

@chengfang0911
Copy link
Author

also on windows 10 if you press alt when app start.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look at fixing this! Unfortunately we can't accept the change in this way because renaming i18n json files has a lot of side effects we want to avoid.

Instead, it sounds like the code which tries to use the translation files needs to be investigated and fixed to ensure it using the same language codes as the rest of the app.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chengfang.ai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dbkr
Copy link
Member

dbkr commented Sep 9, 2024

Closing as this looks inactive.

@dbkr dbkr closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants