Add support for in-app notifications.

[pixlwave]

The old in app notifications UI from the app delegate was an alert which was rather obtrusive. However PushNotificationService includes a way for a notification to request native in-app presentation (and makes sure to only do so if the room is not currently visible). This PR adds a setting that is checked in the service alongside the notification content and removes the old UI.

Could do with direction from Product on whether

1. A setting is definitely needed or this should be always on?
2. If the setting is kept, whether it should be enabled or disabled by default?
3. The string (re-used from MatrixKit) should be updated to use sentence case like the other settings?
4. If the setting should go further down in the list (looking at it now I think it should probably come after the "Device notifications" row)?

Fixes #1108.

Settings	Notification

[pixlwave]

The Alert option was deprecated in iOS 14. I'm not sure what this means for the Constants.userInfoKeyPresentNotificationOnForeground check: one change could be to include it in notification centre too if that is set, but that didn't seem worthwhile to me.

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/WQGm4c

[amshakal]

Hi there, thanks for working on this. Here is my repsonse to the questions:

• A setting is definitely needed or this should be always on? - A setting should be there for this
• If the setting is kept, whether it should be enabled or disabled by default? - Can we enable this if the user selects 'allow notifications'?
• The string (re-used from MatrixKit) should be updated to use sentence case like the other settings? - Sure! :D
• If the setting should go further down in the list (looking at it now I think it should probably come after the "Device notifications" row)? - Yes, that seems right

Additionaly, I would imagine that the notification banner will have the avatar of the user and not element's logo?

@daniellekirkwood let me know if you disagree with any of this.

[pixlwave]

Super thanks for the feedback.

Can we enable this if the user selects 'allow notifications'?

Yep, it will only work if the user allows notifications, so leaving it as enabled by default with give this exact behaviour.

Additionaly, I would imagine that the notification banner will have the avatar of the user and not element's logo?

Sadly this is the system notification banner so it is shown as is. However! There is an issue (#4710) and an oldish community PR (#4819) to enable this style on iOS 15, so there is potential this will happen separately at some stage.

Updated Settings Screen:

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[Anderas]

This is great action. One thing I am not clear on is the check to not show notifications for the currently open room. Where is this implemented?

[Anderas]

Nice chunk of code gone 🎉

[pixlwave]

One thing I am not clear on is the check to not show notifications for the currently open room. Where is this implemented?

There's a check on LegacyAppDelegate.visibleRoomId which is set/cleared by RoomViewController when the room appears/disappears.

[Anderas]

One thing I am not clear on is the check to not show notifications for the currently open room. Where is this implemented?

There's a check on LegacyAppDelegate.visibleRoomId which is set/cleared by RoomViewController when the room appears/disappears.

Ah indeed, thanks