Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new dm crash with RTE is enabled #7692

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

alfogrillo
Copy link
Contributor

Fix #7689

@alfogrillo alfogrillo requested review from a team, pixlwave, stefanceriu and Velin92 and removed request for a team October 3, 2023 15:15
@alfogrillo alfogrillo self-assigned this Oct 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (f1b6f52) 11.85% compared to head (df21fa7) 12.37%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7692      +/-   ##
===========================================
+ Coverage    11.85%   12.37%   +0.51%     
===========================================
  Files         1650     1650              
  Lines       163857   163866       +9     
  Branches     67216    67265      +49     
===========================================
+ Hits         19429    20277     +848     
+ Misses      143791   142921     -870     
- Partials       637      668      +31     
Flag Coverage Δ
uitests 54.97% <ø> (-0.06%) ⬇️
unittests 6.22% <0.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...ogin/Common/Service/MatrixSDK/QRLoginService.swift 6.92% <0.00%> (-0.18%) ⬇️

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo merged commit 7010a69 into develop Oct 4, 2023
17 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/fix-rte-crash branch October 4, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash creating new DM when the new WYSIWYG is enabled
2 participants