Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding to end a Jitsi call for everyone successfully ends the call for the user. #7705

Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 6, 2023

fixes #7704

@Velin92 Velin92 requested a review from pixlwave November 6, 2023 15:46
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget the changelog 😉

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (709f078) 12.37% compared to head (f23dcf1) 12.37%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7705   +/-   ##
========================================
  Coverage    12.37%   12.37%           
========================================
  Files         1650     1650           
  Lines       163866   163869    +3     
  Branches     67264    67267    +3     
========================================
+ Hits         20274    20277    +3     
  Misses      142924   142924           
  Partials       668      668           
Flag Coverage Δ
unittests 6.22% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Velin92 Velin92 merged commit e7a93de into develop Nov 6, 2023
9 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_ending_jistsi_call_when_removing_widget branch November 6, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jitsi calls do not dismiss when they are ended by the host for everyone.
2 participants