Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jitsi call ends if the jitsi widget is removed from the room #7707

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Jitsi call ends if the jitsi widget is removed from the room #7707

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6be83ec
this fixes the issue but might require an extra check to be safe
Velin92 Nov 7, 2023
3a1f5d5
fix completed
Velin92 Nov 7, 2023
7b7f14a
changelog
Velin92 Nov 7, 2023
75e17b6
Merge branch 'develop' into mauroromito/end_call_when_deleting_widget
Velin92 Nov 7, 2023
f759ce4
safer check
Velin92 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Riot/Managers/Widgets/WidgetManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,10 @@ - (void)addMatrixSession:(MXSession *)mxSession

// Broadcast the generic notification
[[NSNotificationCenter defaultCenter] postNotificationName:kWidgetManagerDidUpdateWidgetNotification object:widget];
// End jitsi call if a active call exists and widget has been updated to not be active
if ([[AppDelegate theDelegate].callPresenter.jitsiVC.widget.widgetId isEqualToString: widget.widgetId] && !widget.isActive) {
[[AppDelegate theDelegate].callPresenter endActiveJitsiCall];
}
}
else
{
Expand Down
1 change: 1 addition & 0 deletions changelog.d/7706.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
If a Jitsi call in a room is ongoing when the Jitsi widget is removed from such room the call ends.
Loading