Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CocoaPods and other gems. #7720

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Update CocoaPods and other gems. #7720

merged 1 commit into from
Nov 28, 2023

Conversation

pixlwave
Copy link
Member

There's an issue with Cocoapods 0.13 and ActiveSupport 17.1 so this updates to 0.14 which has a fix for the issue. Companion to matrix-org/matrix-ios-sdk#1835

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pixlwave pixlwave requested review from a team and nimau and removed request for a team November 28, 2023 12:21
Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bd03be) 12.38% compared to head (cd1e4bc) 12.39%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7720   +/-   ##
========================================
  Coverage    12.38%   12.39%           
========================================
  Files         1650     1650           
  Lines       163918   163918           
  Branches     66406    66409    +3     
========================================
+ Hits         20309    20312    +3     
+ Misses      142941   142938    -3     
  Partials       668      668           
Flag Coverage Δ
uitests 55.03% <ø> (+0.01%) ⬆️
unittests 6.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 902aa7b into develop Nov 28, 2023
13 checks passed
@pixlwave pixlwave deleted the doug/update-cocoapods branch November 28, 2023 13:04
Fang-NB-Plus pushed a commit to innet8/element-ios that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants